New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FastSpeech2 using wrong control for energy #225

Merged

RMSnow merged 1 commit into open-mmlab:main from SapphireLab:fix-fs2

Jul 15, 2024

Contributor

SapphireLab commented Jun 23, 2024

✨ Description

Caution

The input variable p_control is wrong for self.get_energy_embedding, it should be e_control as used in the former code.

🚧 Related Issues

👨‍💻 Changes Proposed

change p_control to e_control.

🧑‍🤝‍🧑 Who Can Review?

🛠 TODO

✅ Checklist

Code has been reviewed
Code complies with the project's code standards and best practices
Code has passed all tests
Code does not affect the normal use of existing features
Code has been commented properly
Documentation has been updated (if applicable)
Demo/checkpoint has been attached (if applicable)


          fix e-control

0957c5e

RMSnow requested a review from jiaqili3

June 24, 2024 06:04

jiaqili3 approved these changes

View reviewed changes

Collaborator

jiaqili3 left a comment

LGTM

RMSnow merged commit f00c3ac into open-mmlab:main

1 check passed

SapphireLab deleted the fix-fs2 branch

July 21, 2024 18:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet